actions/gradle
1
0
Fork 0
mirror of https://github.com/gradle/actions.git synced 2026-05-14 04:40:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use a unique cache entry for wrapper-validation test (#921)

Browse Source 
This is necessary to avoid loading a cache entry from a different test,
where the allowed wrapper checksums might have been cached, causing the
wrapper validation to unexpectedly succeed.
This commit is contained in:
Daz DeBoer 2026-03-31 22:16:59 -06:00 committed by GitHub
parent 263d8fe18e
commit 0b8fa27eb1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/integ-test-wrapper-validation.yml vendored
View File

@ -12,6 +12,7 @@ on:
env: env:
SKIP_DIST: ${{ inputs.skip-dist }} SKIP_DIST: ${{ inputs.skip-dist }}
GRADLE_BUILD_ACTION_CACHE_KEY_PREFIX: wrapper-validation- # Avoid loading cache entries from other tests, that may have cached allowed wrapper checksums
permissions: permissions:
contents: read contents: read

1
sources/src/wrapper-validation/wrapper-validator.ts
View File

@ -36,5 +36,6 @@ export async function validateWrappers(
) )
} }
// TODO: Should not be caching the ALLOWED_GRADLE_WRAPPER_CHECKSUMS as they should only apply to the present run
checksumCache.save(result.valid.map(wrapper => wrapper.checksum)) checksumCache.save(result.valid.map(wrapper => wrapper.checksum))
} }